11063
0
true
2009-05-19T12:43:01-04:00
11063
2009-05-18T20:00:00-04:00
40236
2
date-property-subtraction-bug
2
30941
resolved
Date Property subtraction bug
2009-05-19T16:28:53-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
0.0.8
Reported by Paul Scott-Murphy
I saw the following stack trace just now when testing an iCalendar
file.
TypeError: expected numeric or date
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/
ruby/1.8/date.rb:1220:in `-'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `send'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `method_missing'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:163:in `set_occurrence_properties!'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:171:in `recurrence'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:105:in `each'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:137:in `occurrences'
from (irb):27
from (irb):26:in `each'
from (irb):26
from :0
It looks like the use of method_missing in RiCal::PropertyValue::Date
isn't correct when invoking the - method, as the ::Date class requires
the argument sent to that method to be a ::Numeric or ::Date.
I added the following test for this in date_spec.rb:
describe ".-" do
it "should return duration for two instances" do
dt1 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090519"))
dt2 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090518"))
(dt1 - dt2).should == 1
end
end
And made the test pass with this additional method in
RiCal::PropertyValue::Date
def - (x)
self.ruby_value - x.ruby_value
end
There may be other instances of using the - or + methods on
RiCal::PropertyValue classes elsewhere too, which I haven't looked at.
Reported by Paul Scott-Murphy
I saw the following stack trace just now when testing an iCalendar
file.
TypeError: expected numeric or date
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/
ruby/1.8/date.rb:1220:in `-'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `send'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `method_missing'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:163:in `set_occurrence_properties!'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:171:in `recurrence'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:105:in `each'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:137:in `occurrences'
from (irb):27
from (irb):26:in `each'
from (irb):26
from :0
It looks like the use of method_missing in RiCal::PropertyValue::Date
isn't correct when invoking the - method, as the ::Date class requires
the argument sent to that method to be a ::Numeric or ::Date.
I added the following test for this in date_spec.rb:
describe ".-" do
it "should return duration for two instances" do
dt1 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090519"))
dt2 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090518"))
(dt1 - dt2).should == 1
end
end
And made the test pass with this additional method in
RiCal::PropertyValue::Date
def - (x)
self.ruby_value - x.ruby_value
end
There may be other instances of using the - or + methods on
RiCal::PropertyValue classes elsewhere too, which I haven't looked at.
<div><p>Reported by Paul Scott-Murphy</p>
<p>I saw the following stack trace just now when testing an
iCalendar file.</p>
<p>TypeError: expected numeric or date</p>
<pre>
<code> from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/
</code>
</pre>
<p>ruby/1.8/date.rb:1220:in <code>-'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
</code>
</pre>
<p>120:in <code>send'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
</code>
</pre>
<p>120:in <code>method_missing'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:163:in
<code>set_occurrence_properties!'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:171:in <code>recurrence'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:105:in <code>each'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:118:in <code>to_a'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:118:in <code>to_a'</code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
</code>
</pre>
<p>occurrence_enumerator.rb:137:in <code>occurrences'</code></p>
<pre>
<code> from (irb):27
from (irb):26:in `each'
from (irb):26
from :0
</code>
</pre>
<p>It looks like the use of method_missing in
RiCal::PropertyValue::Date isn't correct when invoking the -
method, as the ::Date class requires the argument sent to that
method to be a ::Numeric or ::Date.</p>
<p>I added the following test for this in date_spec.rb:</p>
<p>describe ".-" do</p>
<pre>
<code> it "should return duration for two instances" do
dt1 = RiCal::PropertyValue::Date.new(nil, :value =>
</code>
</pre>
<p>DateTime.parse("20090519"))</p>
<pre>
<code> dt2 = RiCal::PropertyValue::Date.new(nil, :value =>
</code>
</pre>
<p>DateTime.parse("20090518"))</p>
<pre>
<code> (dt1 - dt2).should == 1
end
</code>
</pre>
<p>end</p>
<p>And made the test pass with this additional method in
RiCal::PropertyValue::Date</p>
<pre>
<code> def - (x)
self.ruby_value - x.ruby_value
end
</code>
</pre>
<p>There may be other instances of using the - or + methods on
RiCal::PropertyValue classes elsewhere too, which I haven't looked
at.</p></div>
11063
0
Reported by Paul Scott-Murphy
I saw the following stack trace just now when testing an iCalendar
file.
TypeError: expected numeric or date
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/
ruby/1.8/date.rb:1220:in `-'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `send'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:
120:in `method_missing'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:163:in `set_occurrence_properties!'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:171:in `recurrence'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:105:in `each'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:118:in `to_a'
from /Users/paulsm/Projects/ri_cal/lib/ri_cal/
occurrence_enumerator.rb:137:in `occurrences'
from (irb):27
from (irb):26:in `each'
from (irb):26
from :0
It looks like the use of method_missing in RiCal::PropertyValue::Date
isn't correct when invoking the - method, as the ::Date class requires
the argument sent to that method to be a ::Numeric or ::Date.
I added the following test for this in date_spec.rb:
describe ".-" do
it "should return duration for two instances" do
dt1 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090519"))
dt2 = RiCal::PropertyValue::Date.new(nil, :value =>
DateTime.parse("20090518"))
(dt1 - dt2).should == 1
end
end
And made the test pass with this additional method in
RiCal::PropertyValue::Date
def - (x)
self.ruby_value - x.ruby_value
end
There may be other instances of using the - or + methods on
RiCal::PropertyValue classes elsewhere too, which I haven't looked at.
<div><p>Reported by Paul Scott-Murphy</p>
<p>I saw the following stack trace just now when testing an
iCalendar<br>
file.</p>
<p>TypeError: expected numeric or date<br></p>
<pre>
<code> from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/</code>
</pre>
<p>ruby/1.8/date.rb:1220:in <code>-'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:</code>
</pre>
<p>120:in <code>send'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:</code>
</pre>
<p>120:in <code>method_missing'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:163:in
<code>set_occurrence_properties!'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:171:in
<code>recurrence'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:105:in
<code>each'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:118:in
<code>to_a'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:118:in
<code>to_a'<br/></code></p>
<pre>
<code> from /Users/paulsm/Projects/ri_cal/lib/ri_cal/</code>
</pre>
<p>occurrence_enumerator.rb:137:in
<code>occurrences'<br/></code></p>
<pre>
<code> from (irb):27
from (irb):26:in `each'
from (irb):26
from :0</code>
</pre>
<p>It looks like the use of method_missing in
RiCal::PropertyValue::Date<br>
isn't correct when invoking the - method, as the ::Date class
requires<br>
the argument sent to that method to be a ::Numeric or ::Date.</p>
<p>I added the following test for this in date_spec.rb:</p>
<p>describe ".-" do</p>
<pre>
<code> it "should return duration for two instances" do
dt1 = RiCal::PropertyValue::Date.new(nil, :value =></code>
</pre>
<p>DateTime.parse("20090519"))<br></p>
<pre>
<code> dt2 = RiCal::PropertyValue::Date.new(nil, :value =></code>
</pre>
<p>DateTime.parse("20090518"))<br></p>
<pre>
<code> (dt1 - dt2).should == 1
end</code>
</pre>
<p>end</p>
<p>And made the test pass with this additional method in<br>
RiCal::PropertyValue::Date</p>
<pre>
<code> def - (x)
self.ruby_value - x.ruby_value
end</code>
</pre>
<p>There may be other instances of using the - or + methods on<br>
RiCal::PropertyValue classes elsewhere too, which I haven't looked
at.</p></div>
false
2009-05-19T12:43:01-04:00
11063
--- {}
2
date-property-subtraction-bug
0
30941
new
Date Property subtraction bug
2009-05-19T12:43:05-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
11063
0
I replied:
Thanks Paul.
Although there is a bug here. I'm not sure that the fix is correct,
although I haven't had my coffee yet this morning.
I'm pretty sure that subtracting two PropertyValue::Dates should
result in a PropertyValue::Duration rather than an Integer.
Could you send me the icalendar file which caused the failure?
<div><p>I replied:<br>
Thanks Paul.</p>
<p>Although there is a bug here. I'm not sure that the fix is
correct,<br>
although I haven't had my coffee yet this morning.</p>
<p>I'm pretty sure that subtracting two PropertyValue::Dates
should<br>
result in a PropertyValue::Duration rather than an Integer.</p>
<p>Could you send me the icalendar file which caused the
failure?</p></div>
false
2009-05-19T12:43:36-04:00
11063
--- {}
2
date-property-subtraction-bug
0
30941
new
Date Property subtraction bug
2009-05-19T12:43:37-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
11063
0
Paul later added:
Having read through how the DateTime class handles this, I'm not sure
that the fix is quite right now. That said, there's still a bug.
--Paul
<div><p>Paul later added:</p>
<p>Having read through how the DateTime class handles this, I'm not
sure<br>
that the fix is quite right now. That said, there's still a
bug.</p>
<p>--Paul</p></div>
false
2009-05-19T12:44:06-04:00
11063
--- {}
2
date-property-subtraction-bug
0
30941
new
Date Property subtraction bug
2009-05-19T12:44:08-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
11063
0
Okay,
date - date will now produce a duration
date - datetime will also produce a duration
date - duration will produce a datetime
date + duration will produce a datetime
<div><p>Okay,</p>
<p>date - date will now produce a duration<br>
date - datetime will also produce a duration<br>
date - duration will produce a datetime<br>
date + duration will produce a datetime</p></div>
false
2009-05-19T16:18:57-04:00
11063
--- {}
2
date-property-subtraction-bug
0
30941
new
Date Property subtraction bug
2009-05-19T16:18:57-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
11063
0
true
2009-05-19T16:28:53-04:00
11063
---
:state: new
:milestone:
40236
2
date-property-subtraction-bug
0
30941
resolved
Date Property subtraction bug
2009-05-19T16:28:53-04:00
11063
Rick DeNatale
Rick DeNatale
Rick DeNatale
http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
0.0.8